[PATCH] D90129: Better source location for -Wignored-qualifiers on trailing return types

Aaron Puchert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 28 07:21:37 PDT 2020


aaronpuchert marked an inline comment as done.
aaronpuchert added inline comments.


================
Comment at: clang/include/clang/Sema/DeclSpec.h:1509
+    SourceLocation getTrailingReturnTypeLoc() const {
+      return SourceLocation::getFromRawEncoding(TrailingReturnTypeLoc);
+    }
----------------
aaron.ballman wrote:
> Should we `assert(HasTrailingReturnType);`?
Makes sense to me. Ok if I add the assertion to this and the previous function for consistency?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90129/new/

https://reviews.llvm.org/D90129



More information about the cfe-commits mailing list