[PATCH] D90174: [HIP] Fix regressions due to fp contract change
Artem Belevich via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 26 11:42:31 PDT 2020
tra added inline comments.
================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:486
+ if (LangOpts.HIP)
+ Options.AllowFPOpFusion = llvm::FPOpFusion::Standard;
+
----------------
I don't think it's a good idea to force this.
Perhaps a better way to address this would be to set HIP-specific default to Standard where CUDA does it:
https://github.com/llvm/llvm-project/blob/master/clang/lib/Frontend/CompilerInvocation.cpp#L2415
Currently HIP inherits this setting from CUDA.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90174/new/
https://reviews.llvm.org/D90174
More information about the cfe-commits
mailing list