[PATCH] D90174: [HIP] Fix regressions due to fp contract change

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 26 11:15:18 PDT 2020


yaxunl added a comment.

In D90174#2354249 <https://reviews.llvm.org/D90174#2354249>, @rjmccall wrote:

> I have objections to the code change here.  I'll leave the conceptual question to other people interested in the HIP toolchain.

Is it OK to introduce a clang codegen option e.g. -fp-contract-backend=x to control the backend fp fuse option? By default it matches -ffp-contract language option, but allows being overridden by explicit option. Then HIP toolchain can use it to override the backend fp fuse option.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90174/new/

https://reviews.llvm.org/D90174



More information about the cfe-commits mailing list