[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 26 07:03:43 PDT 2020


kbobyrev added a comment.

Hmm, I see. From the looks of it, the solution for several projects would be

  add_compile_options("$<$<C_COMPILER_ID:MSVC>:/utf-8>")
  add_compile_options("$<$<CXX_COMPILER_ID:MSVC>:/utf-8>")

But I'm not sure if it makes sense in our case and I don't see many `add_compile_options` in LLVM. Also, I don't have a way to test it out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90116/new/

https://reviews.llvm.org/D90116



More information about the cfe-commits mailing list