[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 26 03:21:37 PDT 2020
sammccall added a comment.
This isn't the only place where we use such characters. While I'm not sure spelling these literally is a hill we want to die on, I think u8 literals are so poorly understood that trying to do this consistently isn't going to be that simple.
As noted, clang is always reading as utf-8. gcc is more complicated but we have no reports of this problem. So I think we should assume this is msvc-only and if we can find a CMake workaround we should take it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90116/new/
https://reviews.llvm.org/D90116
More information about the cfe-commits
mailing list