[PATCH] D89971: [OpenMP][CUDA] Add missing overload for `remquo(float,float,int*)`

Thu Oct 22 12:27:32 PDT 2020

jdoerfert added inline comments.

================
Comment at: clang/lib/Headers/__clang_cuda_cmath.h:330
     double>::type
 remquo(__T1 __x, __T2 __y, int *__quo) {
   return std::remquo((double)__x, (double)__y, __quo);
----------------
tra wrote:
> jdoerfert wrote:
> > The template overload I was talking about is this one.
> Ah. It makes more sense now.
> 
> The patch description may need to be rephrased. You've added a function overload, but the description talks about the template which is *not* in the patch.
> Something like `Added function overload for remquo(float...)...   the template function overload for other types... is still behind OPENMP_NVPTX`
Will do:

    Not affected by this patch is the `remquo` template overload which is
    still hidden behind an ifdef for OpenMP. In the future we probably want
    to remove the ifdef but that requires further testing.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89971/new/

https://reviews.llvm.org/D89971