[PATCH] D89529: [clangd][remote] Add Windows paths support

Mon Oct 19 08:19:54 PDT 2020

ArcsinX added a comment.

In D89529#2338794 <https://reviews.llvm.org/D89529#2338794>, @kbobyrev wrote:

> Thank you for the patch! Ready to land it now.

Thank you for review!

> Please update the patch message before commiting though:
>
>> Without this patch 7 marshalling tests fails on Windows.

7 => 6

>> This patch contains the following changes:
>> Allow paths with Windows slashes.
>
> This is not correct anymore, right?

We allow paths with Windows slashes now (convert to the POSIX style instead of assertion). I have updated description about this.

>> Add support for URI with Windows path.
>> Change the value of the second parameter of several llvm::sys::path::convert_to_slash() calls: We should use windows instead of posix to ensure UNIX slashes in the path.
>> Remove part of RemoteMarshallingTest::IncludeHeaderURI test which could not be ported on Windows.
>
> This should not be the case anymor.

I have changed: "Remove" => "Port to Windows"

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89529/new/

https://reviews.llvm.org/D89529