[PATCH] D89529: [clangd][remote] Add Windows paths support
Kirill Bobyrev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 19 07:22:50 PDT 2020
kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.
Thank you for the patch! Ready to land it now.
Please update the patch message before commiting though:
> Without this patch 7 marshalling tests fails on Windows.
> This patch contains the following changes:
> Allow paths with Windows slashes.
This is not correct anymore, right?
> Add support for URI with Windows path.
> Change the value of the second parameter of several llvm::sys::path::convert_to_slash() calls: We should use windows instead of posix to ensure UNIX slashes in the path.
> Remove part of RemoteMarshallingTest::IncludeHeaderURI test which could not be ported on Windows.
This should not be the case anymor.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89529/new/
https://reviews.llvm.org/D89529
More information about the cfe-commits
mailing list