[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

Leonard Chan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 13 11:47:57 PDT 2020


leonardchan marked an inline comment as done.
leonardchan added inline comments.


================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3469
+
+  // The value can be empty, which indicates the system default should be used.
+  StringRef CXXABI = Args.getLastArgValue(OPT_fcxx_abi_EQ);
----------------
phosek wrote:
> Other flags like `-funwindlib` use either empty string or `"platform"`, perhaps we should support the same for `-fc++-abi`?
Would an empty string already imply the platform default ABI? If so, I believe this already handles that case in `ASTContext::getCXXABIKind` when getting the ABI kind.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85802/new/

https://reviews.llvm.org/D85802



More information about the cfe-commits mailing list