[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 12 17:14:38 PDT 2020


phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang/include/clang/Basic/LangOptions.h:299
+  /// This overrides the default ABI used by the target.
+  llvm::Optional<TargetCXXABI::Kind> CXXABIOverride;
+
----------------
I'd call it just `CXXABI` which matches the other variables.


================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3469
+
+  // The value can be empty, which indicates the system default should be used.
+  StringRef CXXABI = Args.getLastArgValue(OPT_fcxx_abi_EQ);
----------------
Other flags like `-funwindlib` use either empty string or `"platform"`, perhaps we should support the same for `-fc++-abi`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85802/new/

https://reviews.llvm.org/D85802



More information about the cfe-commits mailing list