[PATCH] D88630: [clang/CMake] Respect LLVM_TOOLS_INSTALL_DIR
Keno Fischer via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 30 19:20:59 PDT 2020
loladiro created this revision.
loladiro added a reviewer: tstellar.
Herald added subscribers: cfe-commits, mgorny.
Herald added a project: clang.
loladiro requested review of this revision.
Otherwise clang installs all of its tools into `bin/` while
LLVM installs its tools into (LLVM_TOOLS_INSTALL_DIR).
I could swear this used to work (and in fact the julia build system
assumes it), but I can't pin down a specific commit that would
have broken this, and julia has been relying on pre-compiled binaries
for a while now (that don't use this setting), so it may have been
broken for quite a while.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D88630
Files:
clang/cmake/modules/AddClang.cmake
Index: clang/cmake/modules/AddClang.cmake
===================================================================
--- clang/cmake/modules/AddClang.cmake
+++ clang/cmake/modules/AddClang.cmake
@@ -170,7 +170,7 @@
install(TARGETS ${name}
${export_to_clangtargets}
- RUNTIME DESTINATION bin
+ RUNTIME DESTINATION ${LLVM_TOOLS_INSTALL_DIR}
COMPONENT ${name})
if(NOT LLVM_ENABLE_IDE)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88630.295455.patch
Type: text/x-patch
Size: 413 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201001/267b2227/attachment.bin>
More information about the cfe-commits
mailing list