[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

Zoe Carver via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 30 18:08:02 PDT 2020


zoecarver added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1704
+            ->getArrayElementTypeNoTypeQual()
+            ->isRecordType()) {
+      auto FieldElement = CGF.Builder.CreateStructGEP(Ptr, Index);
----------------
Is it OK to possibly create hundreds of stores here? I assume later optimizations will catch this and turn it into a loop or a call to memset or something. But this could potentially be harmful to code size.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87974/new/

https://reviews.llvm.org/D87974



More information about the cfe-commits mailing list