[PATCH] D88336: [ubsan] nullability-arg: Fix crash on C++ member function pointers

Akira Hatanaka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 25 18:18:01 PDT 2020


ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang/lib/CodeGen/CGExpr.cpp:1181
+  if (T->isMemberPointerType())
+    return CGM.getCXXABI().EmitMemberPointerIsNotNull(
+        *this, V, T->getAs<MemberPointerType>());
----------------
You can fold `T->getAs<MemberPointerType>()` into the condition of the if statement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88336/new/

https://reviews.llvm.org/D88336



More information about the cfe-commits mailing list