[PATCH] D88336: [ubsan] nullability-arg: Fix crash on C++ member function pointers

Vedant Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 25 17:08:06 PDT 2020


vsk added a comment.

In D88336#2296051 <https://reviews.llvm.org/D88336#2296051>, @ahatanak wrote:

> It looks like this still doesn't check null correctly (i.e., compare to -1) for data member pointers. Is that correct?

Thanks for catching this. The new revision takes advantage of CXXABI::EmitMemberPointerIsNotNull, so null data member pointers are now diagnosed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88336/new/

https://reviews.llvm.org/D88336



More information about the cfe-commits mailing list