[PATCH] D88195: Remove stale assert.

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 24 10:25:44 PDT 2020


nickdesaulniers added a comment.

I'm super confused between the commit message and initial hunk, that seem to make sense and probably should go in clang-11 if it's not too late, and the additional tests for modules which the commit message does not address.  Were these meant to be separate commits, because otherwise it looks like you uploaded unrelated stuff.  Are C++20 modules broken with `asm goto`, or are you just adding additional test coverage for that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88195/new/

https://reviews.llvm.org/D88195



More information about the cfe-commits mailing list