[PATCH] D88195: Remove stale assert.

[James Y Knight via Phabricator via cfe-commits]

jyknight added inline comments.


================
Comment at: clang/test/Modules/asm-goto.cpp:1
+// RUN: rm -rf %t
+// RUN: %clang_cc1 -fmodules -fno-implicit-modules -x c++ -I%S/Inputs/asm-goto -emit-module %S/Inputs/asm-goto/module.modulemap -fmodule-name=a -o %t/a.pcm
----------------
void wrote:
> jyknight wrote:
> > New test seems to be failing on the autobuilders (yay pre-submit autobuilders!!) for 2 reasons:
> > 1. C++ function-name mangling on Windows is different.
> > 2. "$0 = callbr" != "%0 = callbr"
> > 
> Don't know why I did that. Fixed. :)
Still have problem 1, that @"?foo@@YAHXZ"() != @_Z3foov

Probably simplest to just do
extern "C" {
int foo() {...}
}

to avoid name mangling.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88195/new/

https://reviews.llvm.org/D88195