[PATCH] D87143: Check whether Gentoo-specific configuration directory exists

[Michał Górny via Phabricator via cfe-commits]

mgorny added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2537-2538
     const SmallVectorImpl<StringRef> &CandidateBiarchTriples) {
+  if (!D.getVFS().exists(GentooConfigDir))
+    return false;
+
----------------
manojgupta wrote:
> I think it should be D.SysRoot + GentooConfigDir. Otherwise, there is no way to test a Gentoo configuration tests on a non-Gentoo machine.
Probably correct, given that D.SysRoot is used below. However, this code is a bit above my pay grade and I was never sure whether it's doing right what it's supposed to do. I would really prefer if someone higher up reviewed this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87143/new/

https://reviews.llvm.org/D87143