[PATCH] D87143: Check whether Gentoo-specific configuration directory exists

Manoj Gupta via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 4 09:43:07 PDT 2020


manojgupta added a reviewer: mgorny.
manojgupta added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2537-2538
     const SmallVectorImpl<StringRef> &CandidateBiarchTriples) {
+  if (!D.getVFS().exists(GentooConfigDir))
+    return false;
+
----------------
I think it should be D.SysRoot + GentooConfigDir. Otherwise, there is no way to test a Gentoo configuration tests on a non-Gentoo machine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87143/new/

https://reviews.llvm.org/D87143



More information about the cfe-commits mailing list