[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

Andrew Gallagher via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 28 12:28:31 PDT 2020


andrewjcg added a comment.

> Can you add a simple testcase to prove the point of the change?

Yup, will do!



================
Comment at: clang/lib/Frontend/FrontendAction.cpp:814
+        CI.getPreprocessor().getHeaderSearchInfo().loadModuleMapFile(
+            *File, /*IsSystem*/ false);
+      else
----------------
bruno wrote:
> Is this clang-formatted? 
Ahh, yeah.  Should I avoid this sort of thing (and e.g. instead do this in explicit codemod/refactoring diffs)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86802/new/

https://reviews.llvm.org/D86802



More information about the cfe-commits mailing list