[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled
Bruno Cardoso Lopes via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 28 12:24:02 PDT 2020
bruno added a comment.
Hi Andrew, thanks for improving this. I think this makes sense: dependents can choose to not use modules without having to trigger the build system to rebuild all dependencies. Can you add a simple testcase to prove the point of the change?
================
Comment at: clang/lib/Frontend/FrontendAction.cpp:814
+ CI.getPreprocessor().getHeaderSearchInfo().loadModuleMapFile(
+ *File, /*IsSystem*/ false);
+ else
----------------
Is this clang-formatted?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86802/new/
https://reviews.llvm.org/D86802
More information about the cfe-commits
mailing list