[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

Sun Aug 23 15:24:29 PDT 2020

mikhail.ramalho requested changes to this revision.
mikhail.ramalho added a comment.
This revision now requires changes to proceed.

In D86223#2231991 <https://reviews.llvm.org/D86223#2231991>, @steakhal wrote:

> In D86223#2231959 <https://reviews.llvm.org/D86223#2231959>, @mikhail.ramalho wrote:
>
>> I don't mind having it for release builds as well, why are you applying it only for debug builds?
>
> It might introduce a slight overhead since Z3 will parse longer the symbol names.

That overhead should be negligible, in the worst case you are adding just a few extra characters to the variable's name.

I rather have it for release builds as well so we don't introduce different outputs depending on the build options, and we can improve debugging for release builds as well.

Also as a bonus, we don't have to change the test scripts for a single test.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86223/new/

https://reviews.llvm.org/D86223