[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

[Balázs Benics via Phabricator via cfe-commits]

steakhal added inline comments.


================
Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SMTConv.h:335
+    llvm::raw_svector_ostream OS(Str);
+    OS << PRETTY_SYMBOL_KIND << ID;
+#undef PRETTY_SYMBOL_KIND
----------------
xazax.hun wrote:
> Maybe, in this case, it is cleaner to duplicate the line rather than introduce `PRETTY_SYMBOL_KIND`?
Thanks.


================
Comment at: clang/test/Analysis/z3/pretty-dump.c:15
+    // CHECK: "constraints": [
+    // CHECK-NEXT: { "symbol": "(reg_$[[#]]<int x>) == 3", "range": "(= reg_$[[#]] #x00000003)" }
+  }
----------------
xazax.hun wrote:
> Will this test case work with non-debug builds? 
Fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86223/new/

https://reviews.llvm.org/D86223