[PATCH] D79219: [CMake] Simplify CMake handling for zlib

Sun Aug 23 04:04:35 PDT 2020

mati865 added a comment.

@phosek

> Looks like that's an issue introduced by D86134 <https://reviews.llvm.org/D86134> or D86245 <https://reviews.llvm.org/D86245>.

Indeed, I apologize for bothering you. Should I move the discussion to one of patches created by  @haampie?

Continuing the discussion with `if( CMAKE_FIND_LIBRARY_PREFIXES )` and `if( CMAKE_FIND_LIBRARY_SUFFIXES )` from https://reviews.llvm.org/D86245 changed to false `llvm-config --system-libs` prints `-llibz.dll.a` so we need those replaces to bring back correct `-lz` value.

> Can you print the value of ${CMAKE_FIND_LIBRARY_PREFIXES} and ${CMAKE_FIND_LIBRARY_SUFFIXES} in your build?

  -- CMAKE_FIND_LIBRARY_PREFIXES=lib;
  -- CMAKE_FIND_LIBRARY_SUFFIXES=.dll.a;.a;.lib

Which matches https://gitlab.kitware.com/cmake/cmake/-/blob/269d1a86249ea037a2884133daffc8c44a38d926/Modules/Platform/Windows-GNU.cmake

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79219/new/

https://reviews.llvm.org/D79219