[PATCH] D79219: [CMake] Simplify CMake handling for zlib

Sat Aug 22 19:23:07 PDT 2020

phosek added a comment.

In D79219#2231927 <https://reviews.llvm.org/D79219#2231927>, @mati865 wrote:

> @phosek in MSYS2 (targeting x86_64-w64-windows-gnu) Zlib works properly for LLVM 10 but with master I'm now seeing:
>
>   -- Constructing LLVMBuild project information
>   -- DEBUG zlib_library=D:/msys64/mingw64/lib/libz.dll.a
>   CMake Error at lib/Support/CMakeLists.txt:9 (string):
>     string sub-command REGEX, mode REPLACE: regex "^(lib|)" matched an empty
>     string.
>   Call Stack (most recent call first):
>     lib/Support/CMakeLists.txt:226 (get_system_libname)
>
> `-- DEBUG zlib_library=D:/msys64/mingw64/lib/libz.dll.a` was printed by my change to help debugging it.
> FYI `zlib_library` is set here: https://github.com/llvm/llvm-project/blob/8e06bf6b3a2e8d25e56cd52dca0cf3ff1b37b5d1/llvm/lib/Support/CMakeLists.txt#L218

Looks like that's an issue introduced by D86134 <https://reviews.llvm.org/D86134> or D86245 <https://reviews.llvm.org/D86245>. Can you print the value of `${CMAKE_FIND_LIBRARY_PREFIXES}` and `${CMAKE_FIND_LIBRARY_SUFFIXES}` in your build?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79219/new/

https://reviews.llvm.org/D79219