[PATCH] D86187: [X86] Add support 'tune' in target attribute

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: clang/test/Sema/attr-target.c:26
+//expected-warning at +1 {{unsupported tune 'hiss' in the 'target' attribute string; 'target' attribute ignored}}
+int __attribute__((target("tune=hiss,tune=woof"))) apple_tree() { return 4; }
+
----------------
efriedma wrote:
> "unsupported tune" seems a little weird. For the command-line flag, we print something like "unknown target CPU 'hiss'"; can we use similar wording here, so it's clear why it's not supported?
Sure. Though there is a subtle issue with even the command line version. We print the same message for old CPUs that don't support x86-64. Those cases should probably be "unsupported" rather than "unknown"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86187/new/

https://reviews.llvm.org/D86187