[PATCH] D86187: [X86] Add support 'tune' in target attribute
    Aaron Ballman via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Wed Aug 19 13:28:30 PDT 2020
    
    
  
aaron.ballman added inline comments.
================
Comment at: clang/include/clang/AST/Attr.h:346
+           Tune == Other.Tune &&
+           BranchProtection == Other.BranchProtection &&
+           Features == Other.Features;
----------------
craig.topper wrote:
> Was it a bug that BranchProtection wasn't in the original code?
I just dug out the original review which added it (https://reviews.llvm.org/D68711) and there's no mention of why `BranchProtection` was missed here, so I think it was just a bug.
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86187/new/
https://reviews.llvm.org/D86187
    
    
More information about the cfe-commits
mailing list