[PATCH] D86101: [AArch64][SVE] Add missing debug info for ACLE types.

Richard Sandiford via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 19 03:15:47 PDT 2020


rsandifo-arm added inline comments.


================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:748
+      llvm::DINodeArray SubscriptArray = DBuilder.getOrCreateArray(Subscript);
+      llvm::DIType *ElemTy =
+          getOrCreateType(Info.ElementType, TheCU->getFile());
----------------
I might be misreading the code, but if we're representing svbool_t as a bitmask (which is a good approach IMO), would it be better to pass UnsignedCharTy rather than BoolTy here?  It seems odd to represent the type as <vscale x 2> “bools”.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86101/new/

https://reviews.llvm.org/D86101



More information about the cfe-commits mailing list