[PATCH] D86101: [AArch64][SVE] Add missing debug info for ACLE types.

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 18 14:17:19 PDT 2020


efriedma added inline comments.


================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:734
+      if (Info.ElementType == CGM.getContext().BoolTy)
+        NumElemsPerVG /= 8;
+
----------------
I guess NumElemsPerVG of a bool vector is always divisible by 8 because we don't expose `<vscale x 2 x i1>` etc.?


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:1404
+          ? Subrange->getCount().get<ConstantInt *>()->getSExtValue()
+          : 0;
 
----------------
Do we need a test for this change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86101/new/

https://reviews.llvm.org/D86101



More information about the cfe-commits mailing list