[PATCH] D85324: [z/OS] Add z/OS Target and define macros

[Abhina Sreeskantharajan via Phabricator via cfe-commits]

abhina.sreeskantharajan added inline comments.


================
Comment at: clang/lib/Basic/Targets/OSTargets.h:780
+public:
+  ZOSTargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
+      : OSTargetInfo<Target>(Triple, Opts) {}
----------------
tatyana-krasnukha wrote:
> It is possible to use inheriting constructor here instead (i.e. `using OSTargetInfo<Target>::OSTargetInfo;`).
Thanks Tatyana for your review! I think an inheriting constructor is also a good solution, but in order to maintain consistency with the other  targets' constructors, I would prefer to keep it this way. Please let me know if there is a reason for using inherited constructors for this target, I may have missed something.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85324/new/

https://reviews.llvm.org/D85324