[PATCH] D85324: [z/OS] Add z/OS Target and define macros

Tatyana Krasnukha via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 5 14:40:55 PDT 2020


tatyana-krasnukha added a comment.

I'm not familiar with the z/OS target, so I cannot check the correctness of the target-specific changes. The overall patch looks good.



================
Comment at: clang/lib/Basic/Targets/OSTargets.h:780
+public:
+  ZOSTargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
+      : OSTargetInfo<Target>(Triple, Opts) {}
----------------
It is possible to use inheriting constructor here instead (i.e. `using OSTargetInfo<Target>::OSTargetInfo;`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85324/new/

https://reviews.llvm.org/D85324



More information about the cfe-commits mailing list