[PATCH] D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend

Albion Fung via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 24 15:01:29 PDT 2020


Conanap added a comment.

Addressed formatting comments



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:14156
+
+  // This transformation is only valid if the we are loading either a byte,
+  // halfword, word, or doubleword.
----------------
NeHuang wrote:
> nit: if we are loading either a byte....
I'm not too sure what you mean, would you be able to elaborate?  
The comment is:


> This transformation is only valid if the we are loading either a byte,
> halfword, word, or doubleword.

Thanks!




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82502/new/

https://reviews.llvm.org/D82502





More information about the cfe-commits mailing list