[PATCH] D81728: [InstCombine] Add target-specific inst combining

Jay Foad via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 17 04:47:00 PDT 2020


foad added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:552-555
+  /// \returns false to not do anything target specific or true to return the
+  /// value in \p ResultI from the InstCombiner. It is possible to return null
+  /// and stop further processing of the intrinsic by writing nullptr into
+  /// \p ResultI and returning true.
----------------
Did you consider returning `std::pair<bool,Instruction*>`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81728/new/

https://reviews.llvm.org/D81728





More information about the cfe-commits mailing list