[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

Richard Sandiford via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 16 09:03:22 PDT 2020


rsandifo-arm added a comment.

Thanks for doing this.  FWIW, the patch LGTM from a spec point of view.  I just saw one minor spelling nit.



================
Comment at: clang/include/clang/Basic/AttrDocs.td:4882
+to the SVE predicate type ``svbool_t``, this excludes tuple types such as
+``svint32x4_t``. The behaviour of the attribute is undefined unless
+``N==__ARM_FEATURE_SVE_BITS``, the implementation defined feature macro that is
----------------
nit: s/behaviour/behavior/, since I think the documentation uses US/international English.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83550/new/

https://reviews.llvm.org/D83550





More information about the cfe-commits mailing list