[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 16 07:57:12 PDT 2020
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM aside from a small nit.
================
Comment at: clang/lib/Sema/SemaType.cpp:7698
+ llvm::APSInt &Result) {
+ Expr *AttrExpr = static_cast<Expr *>(Attr.getArgAsExpr(0));
+ if (AttrExpr->isTypeDependent() || AttrExpr->isValueDependent() ||
----------------
`const auto *` and you should use `cast<>` instead of `static_cast<>`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83550/new/
https://reviews.llvm.org/D83550
More information about the cfe-commits
mailing list