[PATCH] D83788: Removed unused variable in clang
Nadav Rotem via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 14 17:53:11 PDT 2020
nadav updated this revision to Diff 278031.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83788/new/
https://reviews.llvm.org/D83788
Files:
clang/lib/Sema/SemaExpr.cpp
Index: clang/lib/Sema/SemaExpr.cpp
===================================================================
--- clang/lib/Sema/SemaExpr.cpp
+++ clang/lib/Sema/SemaExpr.cpp
@@ -15543,7 +15543,6 @@
bool CheckInferredResultType = false;
bool isInvalid = false;
unsigned DiagKind = 0;
- FixItHint Hint;
ConversionFixItGenerator ConvHints;
bool MayHaveConvFixit = false;
bool MayHaveFunctionDiff = false;
@@ -15596,10 +15595,9 @@
}
CheckInferredResultType = DstType->isObjCObjectPointerType() &&
SrcType->isObjCObjectPointerType();
- if (Hint.isNull() && !CheckInferredResultType) {
+ if (!CheckInferredResultType) {
ConvHints.tryToFixConversion(SrcExpr, SrcType, DstType, *this);
- }
- else if (CheckInferredResultType) {
+ } else if (CheckInferredResultType) {
SrcType = SrcType.getUnqualifiedType();
DstType = DstType.getUnqualifiedType();
}
@@ -15768,13 +15766,11 @@
FDiag << FirstType << SecondType << Action << SrcExpr->getSourceRange();
// If we can fix the conversion, suggest the FixIts.
- assert(ConvHints.isNull() || Hint.isNull());
if (!ConvHints.isNull()) {
for (FixItHint &H : ConvHints.Hints)
FDiag << H;
- } else {
- FDiag << Hint;
}
+
if (MayHaveConvFixit) { FDiag << (unsigned) (ConvHints.Kind); }
if (MayHaveFunctionDiff)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83788.278031.patch
Type: text/x-patch
Size: 1349 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200715/46314775/attachment.bin>
More information about the cfe-commits
mailing list