[PATCH] D83788: Removed unused variable in clang

Brian Gesiak via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 14 11:25:46 PDT 2020


modocache added a comment.

By the way, I tried to accept this diff and leave the following inline comment on `SemaExpr.cpp:15799`:

> I guess this assert was never capable of being hit previously, since the `FixItHint::isNull` would always return true? I wonder if we'll now see some genuine asserts for `ConversionFixItGenerator::isNull` thanks to this change.

However when I attempt to do either, Phabricator displays a dialog indicating I don't have permission to "modify" the diff. Not sure what's going on there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83788/new/

https://reviews.llvm.org/D83788





More information about the cfe-commits mailing list