[PATCH] D83419: [clangd] Add error() function for creating formatv-style llvm::Errors. NFC

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

> Sorry, I should give some reasons here:

These are sensible reasons. My only (not a strong) concern is that "error" is quite special, we need to be careful to choose it -- note that there is an `error` function in glibc which is used for error-reporting.

maybe there are other better names (`stringError`?) other than `createError`/`makeError`.

> I guess makeError is still better than the status quo, but not enough to feel motivated to clean this up right now. Maybe someone else wants to pick this up?

unless you strongly insist on `error` name, I'm happy to help with (looks like it's just a low-hanging rename fruit). I think this is a nice cleanup, we should make it happen (either using `error` or other names).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83419/new/

https://reviews.llvm.org/D83419