[PATCH] D83419: [clangd] Add error() function for creating formatv-style llvm::Errors. NFC
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 9 00:23:04 PDT 2020
sammccall added a comment.
In D83419#2140889 <https://reviews.llvm.org/D83419#2140889>, @sammccall wrote:
> Honestly, I really dislike names in the style of makeError/createError.
Sorry, I should give some reasons here:
- not discoverable (`error` is marginally better)
- emphasis on allocation rather than how you're using the error (`error` is much better)
- forms part of a cluster of hard to remember names createX vs makeX vs make_x (`error` is much better)
- longer, both in characters and words (`error` is better)
It's just an aesthetic irritation but really this is just an aesthetic cleanup.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83419/new/
https://reviews.llvm.org/D83419
More information about the cfe-commits
mailing list