[PATCH] D83178: [clangd] Send EOF before resetting diagnostics consumer

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

As discussed offline D78038 <https://reviews.llvm.org/D78038> is not going to fix header-guard-check issue, as it relies on not only the PP state, but receiving appropriate callbacks for all of the ifndef/define/endif macros, which is something we don't do in current state.

So sent out D83224 <https://reviews.llvm.org/D83224> to discuss our options around disabling tidy checks. As for checks affected by this change; there seems to be 3 of them, llvm-include-order-check, llvm-header-guard-check and portability-restrict-system-includes, out
of these 3 only the llvm-header-guard requires access to non-include directives, the rest seems to be fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83178/new/

https://reviews.llvm.org/D83178