[PATCH] D83178: [clangd] Send EOF before resetting diagnostics consumer

Mon Jul 6 12:53:52 PDT 2020

njames93 added a comment.

In D83178#2132490 <https://reviews.llvm.org/D83178#2132490>, @kadircet wrote:

> Yeah concerns around header-guard checks are real (and likely to be annoying), so will wait for D78038 <https://reviews.llvm.org/D78038>.
>
> I suppose we can split that into multiple patches, and at least land the bit around preserving conditional stack at the end of preamble, WDYT?

If there are issues with D78038 <https://reviews.llvm.org/D78038> then I'd say this could be landed so long as header-guard (and other) checks were manually disabled til that can be sorted.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83178/new/

https://reviews.llvm.org/D83178