[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

Eric Christopher via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 5 21:04:44 PDT 2020


On Sun, Jul 5, 2020 at 8:47 PM Arthur Eubanks via Phabricator <
reviews at reviews.llvm.org> wrote:

> aeubanks added a comment.
>
> In D83013#2132070 <https://reviews.llvm.org/D83013#2132070>, @echristo
> wrote:
>
> > Adding Chandler and Alina here as well.
> >
> > In general, I don't think that this is such a great idea. Being able to
> have this sort of thing work more reliably is one of the reasons for the
> new pass manager. I think I'd like to see this split out into an old versus
> new pass manager pass to avoid the difficulty of cleaning this up after we
> finish migrating llvm to the new pass manager. This also seems to add some
> technical debt around options and other enablement which is also less than
> ideal. Is this compelling to add right now versus finishing work migrating
> llvm completely to the new pass manager and removing the old one? From
> speaking with Alina I think that work should be done in a short while.
> >
> > Thanks.
> >
> > -eric
>
>
> I don't think we're that close yet, probably at least a couple months out,
> there are lots of loose ends to be tied up. I'll make a post soon in
> llvm-dev (maybe first we can sync up again) about what I think needs to be
> done before the NPM switch.
>
>
Honestly at this point that is a couple of months :) I think we may be able
to speed things up as well.

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200705/a9cb0658/attachment.html>


More information about the cfe-commits mailing list