[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

JunMa via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 15 23:58:07 PDT 2020


junparser added a comment.

@aaron.ballman thanks for the review. I have updated the patch.



================
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2622
     Guard->setThreadLocal(true);
+    Guard->setThreadLocalMode(CGM.GetDefaultLLVMTLSModel());
 
----------------
aaron.ballman wrote:
> Do we need a similar change in `MicrosoftCXXABI::EmitGuardedInit()`? I notice it sets thread local to true but does not set the thread local mode.
Yes, It should be changed as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81543/new/

https://reviews.llvm.org/D81543





More information about the cfe-commits mailing list