[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 15 04:51:54 PDT 2020


aaron.ballman added a comment.

Changes generally LGTM, but this is not my area of expertise.



================
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2622
     Guard->setThreadLocal(true);
+    Guard->setThreadLocalMode(CGM.GetDefaultLLVMTLSModel());
 
----------------
Do we need a similar change in `MicrosoftCXXABI::EmitGuardedInit()`? I notice it sets thread local to true but does not set the thread local mode.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81543/new/

https://reviews.llvm.org/D81543





More information about the cfe-commits mailing list