[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Sat Jun 6 04:14:40 PDT 2020

Daniel599 marked an inline comment as done.
Daniel599 added inline comments.

================
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:777
+                          "or make sure they are both configured the same. "
+                          "Aliased checkers: '{0}', '{1}'",
+                          ExistingError.DiagnosticName, Error.DiagnosticName)
----------------
njames93 wrote:
> You don't really need the Aliased checkers note as that is wrapped in the initial diagnostic message. 
> Also if there was a check that could spew out 3 different fix-its for the same diagnostic, this would result in the duplication note being made twice, maybe the notes should be cleared too?
regarding your comment about 3 fix-it, as we walked before, there isn't a case like that (I didn't find any) as I wanted to make a test out of it.
I added the last line as it would show who are the two that conflict (supporting the future case of more than 2 aliased checkers),
I can remove it if it doesn't help, let me know.

> maybe the notes should be cleared too?
I am open for suggestions about how to re-write this message :)
I also think it could be better

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80753/new/

https://reviews.llvm.org/D80753