[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers
Nathan James via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Jun 6 03:42:47 PDT 2020
njames93 added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:777
+ "or make sure they are both configured the same. "
+ "Aliased checkers: '{0}', '{1}'",
+ ExistingError.DiagnosticName, Error.DiagnosticName)
----------------
You don't really need the Aliased checkers note as that is wrapped in the initial diagnostic message.
Also if there was a check that could spew out 3 different fix-its for the same diagnostic, this would result in the duplication note being made twice, maybe the notes should be cleared too?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80753/new/
https://reviews.llvm.org/D80753
More information about the cfe-commits
mailing list