[PATCH] D31702: Append -w when LLVM_ENABLE_WARNINGS is Off.

[Vassil Vassilev via cfe-commits]

On 6/4/20 6:58 AM, Sean Silva wrote:
> Can we revert this?
>
> In our downstream project we were bitten by this: 
> https://github.com/google/mlir-npcomp/commit/cd7258dbd48bd9254c6741cab2d3f4e36cbd3c84
>
> It seems that now by default anybody that depends on LLVM with CMake 
> will globally get a `-w` passed to their compiler. That doesn't seem 
> like good behavior.


   Wouldn't that be the case for all append clauses in that file?


>
> -- Sean Silva
>
> On Wed, Apr 12, 2017 at 1:56 PM Vassil Vassilev via Phabricator via 
> llvm-commits <llvm-commits at lists.llvm.org 
> <mailto:llvm-commits at lists.llvm.org>> wrote:
>
>     v.g.vassilev closed this revision.
>     v.g.vassilev added a comment.
>
>     Landed in r300100.
>
>
>     https://reviews.llvm.org/D31702
>
>
>
>     _______________________________________________
>     llvm-commits mailing list
>     llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>     http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200604/dda42bc6/attachment.html>