<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">On 6/4/20 6:58 AM, Sean Silva wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAHnXoanj_FFdz_JD_N-Z=Xi_Ngo+gV9gLuTETVzEO55bTAwAcA@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div dir="ltr">Can we revert this?
        <div><br>
        </div>
        <div>In our downstream project we were bitten by this: <a
href="https://github.com/google/mlir-npcomp/commit/cd7258dbd48bd9254c6741cab2d3f4e36cbd3c84"
            moz-do-not-send="true">https://github.com/google/mlir-npcomp/commit/cd7258dbd48bd9254c6741cab2d3f4e36cbd3c84</a></div>
        <div><br>
        </div>
        <div>It seems that now by default anybody that depends on LLVM
          with CMake will globally get a `-w` passed to their compiler.
          That doesn't seem like good behavior.</div>
      </div>
    </blockquote>
    <p><br>
    </p>
    <p>  Wouldn't that be the case for all append clauses in that file?<br>
    </p>
    <p><br>
    </p>
    <blockquote type="cite"
cite="mid:CAHnXoanj_FFdz_JD_N-Z=Xi_Ngo+gV9gLuTETVzEO55bTAwAcA@mail.gmail.com">
      <div dir="ltr">
        <div><br>
        </div>
        <div>-- Sean Silva</div>
      </div>
      <br>
      <div class="gmail_quote">
        <div dir="ltr" class="gmail_attr">On Wed, Apr 12, 2017 at 1:56
          PM Vassil Vassilev via Phabricator via llvm-commits <<a
            href="mailto:llvm-commits@lists.llvm.org"
            moz-do-not-send="true">llvm-commits@lists.llvm.org</a>>
          wrote:<br>
        </div>
        <blockquote class="gmail_quote" style="margin:0px 0px 0px
          0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">v.g.vassilev
          closed this revision.<br>
          v.g.vassilev added a comment.<br>
          <br>
          Landed in r300100.<br>
          <br>
          <br>
          <a href="https://reviews.llvm.org/D31702" rel="noreferrer"
            target="_blank" moz-do-not-send="true">https://reviews.llvm.org/D31702</a><br>
          <br>
          <br>
          <br>
          _______________________________________________<br>
          llvm-commits mailing list<br>
          <a href="mailto:llvm-commits@lists.llvm.org" target="_blank"
            moz-do-not-send="true">llvm-commits@lists.llvm.org</a><br>
          <a
            href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits"
            rel="noreferrer" target="_blank" moz-do-not-send="true">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
        </blockquote>
      </div>
    </blockquote>
    <p><br>
    </p>
  </body>
</html>