[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

[Kadir Çetinkaya via cfe-commits]

thanks for letting me know. it is annoying that the test is flaky, but I
don't see that flakiness on any other buildbot I've access to.

Is there any chance that you are running in a custom build configuration
that I can try to repro the failure? Also what's the falkiness ratio?

On Tue, Jun 2, 2020 at 1:43 AM Wolfgang Pieb via Phabricator <
reviews at reviews.llvm.org> wrote:

> wolfgangp added a comment.
>
> Hi!
>
> Shortly after this patch went in, we started to see intermittent failures
> with the unittest TUSchedulerTests.ManyUpdates. The build server (Windows)
> we're running it on is quite powerful and our own hand-run tests only take
> about 400 ms, so we don't really understand what could be happening. Any
> help would be appreciated.
>
> Here is an excerpt from the log:
>
> Note: Google Test filter = TUSchedulerTests.ManyUpdates
>
> [==========] Running 1 test from 1 test case.
>
> [----------] Global test environment set-up.
>
> [----------] 1 test from TUSchedulerTests
>
> [ RUN      ] TUSchedulerTests.ManyUpdates
>
> C:\j\w\...\clang-tools-extra\clangd\unittests\TUSchedulerTests.cpp(508):
> error: Value of: S.blockUntilIdle(timeoutSeconds(10))
>
>   Actual: false
>
> Expected: true
>
> [  FAILED  ] TUSchedulerTests.ManyUpdates (10576 ms)
>
> [----------] 1 test from TUSchedulerTests (10576 ms total)
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D80293/new/
>
> https://reviews.llvm.org/D80293
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200602/eef513c1/attachment.html>