[PATCH] D80757: [PowerPC] Add clang option -m[no-]pcrel

Fri May 29 13:06:48 PDT 2020

saghir added inline comments.

================
Comment at: clang/test/Driver/ppc-pcrel.cpp:1
+// RUN: %clang -target powerpc64-unknown-linux-gnu %s -### -mcpu=pwr10 -mpcrel -o %t.o 2>&1 | FileCheck -check-prefix=CHECK-PCREL %s
+// RUN: %clang -target powerpc64-unknown-linux-gnu %s -### -mcpu=pwr10 -mno-pcrel -o %t.o 2>&1 | FileCheck -check-prefix=CHECK-NOPCREL %s
----------------
lei wrote:
> saghir wrote:
> > nit: would the first two checks be better off in `clang/test/Driver/ppc-features.cpp`?
> I think it's better to keep all tests for pcrel within this specific pcrel test file.
I don't feel too strongly about where to keep it... there are checks for other target features in `ppc-features.cpp` so felt pcrel feature check could be put there along with other feature checks. 
But feel free to keep them here if you feel that's more appropriate.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80757/new/

https://reviews.llvm.org/D80757