[PATCH] D80757: [PowerPC] Add clang option -m[no-]pcrel

Lei Huang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 29 05:56:47 PDT 2020


lei marked an inline comment as done.
lei added inline comments.


================
Comment at: clang/test/Driver/ppc-pcrel.cpp:1
+// RUN: %clang -target powerpc64-unknown-linux-gnu %s -### -mcpu=pwr10 -mpcrel -o %t.o 2>&1 | FileCheck -check-prefix=CHECK-PCREL %s
+// RUN: %clang -target powerpc64-unknown-linux-gnu %s -### -mcpu=pwr10 -mno-pcrel -o %t.o 2>&1 | FileCheck -check-prefix=CHECK-NOPCREL %s
----------------
saghir wrote:
> nit: would the first two checks be better off in `clang/test/Driver/ppc-features.cpp`?
I think it's better to keep all tests for pcrel within this specific pcrel test file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80757/new/

https://reviews.llvm.org/D80757





More information about the cfe-commits mailing list